BUG: a dot on a line by itself truncates the message

Discussion re sg development. You don't have to be a developer.

BUG: a dot on a line by itself truncates the message

Postby SysKoll » Thu Jan 13, 2005 1:56 am

Josh,

User vsp found a bug that I replicated easily. See
http://images.spamgourmet.com/phpBB2/vi ... .php?t=443

My account forwards to address A1. I send to A1 a short message:
1 This is a test message. It should end with "5 END".
2 Now a dot by itself:
.
4 There is still a line here
5 END


The message arrives intact

Now, I send the same message to a spamgourmet disposable. When it arrives through A1, the mesg is truncated at the end of line 2.
1 This is a test message. It should end with "5 END".
2 Now a dot by itself:


Conclusion: sg trunctates messages with a dot on a line by itself. It's probably because the '.' is seen as a sendmail end-of-message. We need to escape the dots or something. Unless there is a "dot off" option as for the mail command?
-- SysKoll
SysKoll
 
Posts: 884
Joined: Thu Aug 28, 2003 9:24 pm

Postby SysKoll » Thu Jan 13, 2005 3:04 am

Addendum: When I send a message with a line consisting only of two dots, I get the message OK but the line has been changed to only one dot. So that's the way we need to escape a single dot: change it into "..".
-- SysKoll
SysKoll
 
Posts: 884
Joined: Thu Aug 28, 2003 9:24 pm

Postby maratheamit » Thu Jan 13, 2005 4:08 pm

Let's not get into escaping dot characters. A better fix would be to use a perl module to forward messages (say Net::SMTP). The module will do the necessary escaping for us. It will also alleviate the resource crunch we face during peak times because spameater won't be launching a seperate sendmail process for every forwarded message.
maratheamit
 
Posts: 82
Joined: Fri Aug 29, 2003 2:35 pm

Postby SysKoll » Fri Jan 14, 2005 2:15 am

Amit,

You were experimenting with Milters, weren't you? What's the outcome?
-- SysKoll
SysKoll
 
Posts: 884
Joined: Thu Aug 28, 2003 9:24 pm

Postby SysKoll » Fri Jan 14, 2005 5:17 am

This bug is now fixed.
-- SysKoll
SysKoll
 
Posts: 884
Joined: Thu Aug 28, 2003 9:24 pm

Postby josh » Fri Jan 14, 2005 6:50 pm

as a followup, we took care of the bug by changing a line in spamgourmet config. We're now calling command line sendmail with the -O ignoredots option.
josh
 
Posts: 1364
Joined: Fri Aug 29, 2003 2:28 pm

Postby maratheamit » Fri Jan 14, 2005 8:08 pm

I was able to install the perl Milter and get it to communicate with sendmail. However, the Milter-sendmail interface is such that before we can use it in production, there have to be wholesale changes to spameater.pl.

So a first step would be to upgrade the software on the production server. Side-by-side we can think about how to restructure the spameater code.
maratheamit
 
Posts: 82
Joined: Fri Aug 29, 2003 2:35 pm

Resurrection of a bug ?

Postby gverelst » Sun Sep 18, 2011 4:33 pm

Hi developpers of SG

While looking for the keywords "sendmail" on the forum I found this topic - correct since august 2003.

However if one of you can have a look to the recent posts in this:
http://bbs.spamgourmet.com/viewtopic.ph ... 5&start=15

It all looks pretty much the same.
Was the historical correction lost with an upgrate?
Or does this correction needs to be applied on a 2nd place ?

Can somebody of you have a look plz
gverelst
 
Posts: 10
Joined: Tue Nov 21, 2006 2:36 pm


Return to Developers

Who is online

Users browsing this forum: No registered users and 2 guests