Page 2 of 2

Add the sanitizing of the user-typed field

PostPosted: Tue Feb 10, 2004 1:07 am
by SysKoll
Josh,

It looks OK to me. You just need to make sure that whatever the user types in the various fields is not too long and is composed only of accepted characters. This means adding a couple of regexp checks in the Perl code of the "send first message" interface.

PostPosted: Tue Feb 10, 2004 6:37 am
by josh
I *think* this is handled by CGI.pm, which we're using to get the session variables from, and then DBI.pm sanitized any strings that are destined for the datbase, because we only use parameterized SQL through it.

PostPosted: Tue Feb 10, 2004 7:17 am
by josh
the deed is done...

Translations broken

PostPosted: Tue Feb 10, 2004 4:14 pm
by SysKoll
Josh,

The templates in non-EN languages are broken. This is probably because the dialog names changed (addresslink instead of addresspopup for example).

We should either do a search-and-replace on the dialogs you changed in the latest rev, or send an email to all translators immediately.

Meanwhile, 12,000 people are going to complain that their "show my address" link in the non-US advanced mode is not working.

PostPosted: Tue Feb 10, 2004 10:43 pm
by josh
the templates are fixed... :)